feat: insight viz view props #17279
Merged
feat: insight viz view props #17279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
pauldambra
approved these changes
Sep 1, 2023
frontend/src/scenes/insights/filters/ActionFilter/ActionFilterRow/ActionFilterRow.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Towards #15680. We want to add Insights to notebooks but first they need to look good
Changes
InsightViznodeembeddedoption that hides the card wrapping the filters (as it is already contained as part of the notebook)showIfFullwhen a falsey value was provided e.g. ifquery.showHeaderis false thenconst disableHeader = query.showHeader ? !query.showHeader : !showIfFullworks off theshowIfFullvalue which could betrue. What we really want isconst disableHeader = !(query.showHeader ?? showIfFull)which returnsfalse.How did you test this code?
🙈