feat: notebook timestamp nodes #16613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @daibhin! 👋 |
daibhin
force-pushed
the
dn/timestamp-nodes
branch
from
2a542ea
to
1a49325
Compare
|
Conscious that notebooks don't have a lot of tests in them. Would love to pair with someone if there is a way to start adding them in this PR |
benjackwhite
requested changes
Jul 19, 2023
|
@daibhin resolved the comments that were sorted from our pairing. Just some small follow up stuff left 👍 |
daibhin
force-pushed
the
dn/timestamp-nodes
branch
from
36eeb52
to
f511bc4
Compare
daibhin
force-pushed
the
dn/timestamp-nodes
branch
2 times, most recently
from
81b5bea
to
16b7aa9
Compare
daibhin
force-pushed
the
dn/timestamp-nodes
branch
from
16b7aa9
to
183db24
Compare
tomasfarias
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Add comment button to session recordings * Add timestamped playback node * Insert next timestamp item * Style timestamps * Bind node logic * Insert comment at the end of a timestamp list following a recording * Cleanup implementation * Appease the linter * Tweaks from pairing * Improve naming and cleanup unused references --------- Co-authored-by: Ben White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Follow on from #16530
Towards #15680
We don't currently support any type of comments in recordings
Changes
notebookNodeLogicthat is bound in theNodeWrappercomments.mp4
Still to do
Tab'ed for inclusion in the documentHow did you test this code?