feat(hogql): errors for large full select queries #15957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
reviewed
Jun 9, 2023
Comment on lines
21
to
22
| const [monaco, setMonaco] = useState(null as Monaco | null) | ||
| const [editor, setEditor] = useState(null as importedEditor.IStandaloneCodeEditor | null) |
There was a problem hiding this comment.
Nit: Since these come as a package together, I propose just one useState of type [Monaco, importedEditor.IStandaloneCodeEditor] | null
| @@ -129,6 +129,7 @@ export const commonConfig = { | |||
| 'process.env.NODE_ENV': isDev ? '"development"' : '"production"', | |||
| }, | |||
| loader: { | |||
| '.ttf': 'file', | |||
There was a problem hiding this comment.
Got an error when importing from monaco otherwise :/
|
Will this do?
I'm not exposing the "validating..." to the user through a spinner cause I think it'd be flash and annoying. However because of that I'm also not disabling the button when it's loading, and there's a chance someone can still submit an invalid query if they're really fast. But then we show the error below, so 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The full HogQL insight editor does not show errors as well as the inline filter editors.
Changes
Support passing error information from
HogQLMetadatanow.Also cleaned up the location information with antlr syntax errors.
How did you test this code?
See the gif