Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added resizer for Notebooks #15796

Merged
merged 4 commits into from
May 31, 2023
Merged

feat: Added resizer for Notebooks #15796

merged 4 commits into from
May 31, 2023

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented May 30, 2023

Problem

Related to #15680

The notebook sidebar wasn't resizable. This makes it resizable

Changes

  • Adds a resizer component
  • Handles the resizing of the notebook sidebar
  • Didn't share the component with the other 3000 sidebar as that was a bit more involved 😅 @Twixes maybe it's easier with your eyes

2023-05-30 18 13 48

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐉

@benjackwhite benjackwhite merged commit 9d5f9bb into master May 31, 2023
@benjackwhite benjackwhite deleted the feat/resize-notebooks branch May 31, 2023 09:41
@Twixes
Copy link
Collaborator

Twixes commented May 31, 2023

This is good for now, but I'll definitely look into reusing the same logic for all resizing later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants