Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hogql): more functions #14969

Merged
merged 26 commits into from
Apr 6, 2023
Merged

feat(hogql): more functions #14969

merged 26 commits into from
Apr 6, 2023

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Apr 4, 2023

Changes

  • Adds more ClickHouse functions to HogQL.
  • Adds JSON property access split out to a different PR
  • Adds ternary operator support 1 < 3 ? 'red' : 'green'

Stacked on top of #14968

How did you test this code?

"toJSONString": ("toJSONString", 1, 1),
"parseDateTime": ("parseDateTimeOrNull", 2, 2),
"parseDateTimeBestEffort": ("parseDateTimeBestEffortOrNull", 2, 2),
# dates and times TODO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also suggest adding today, saw a user need it a couple weeks ago (toDate(now()) just doesn't roll of the tongue as well)

@mariusandra mariusandra marked this pull request as ready for review April 5, 2023 09:42
Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Seems useful to check for the number of required args.

Base automatically changed from hogql-timezone to master April 6, 2023 08:33
@mariusandra mariusandra enabled auto-merge (squash) April 6, 2023 08:52
@mariusandra mariusandra merged commit 692fa66 into master Apr 6, 2023
@mariusandra mariusandra deleted the hogql-functions branch April 6, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants