-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hogql): more functions #14969
feat(hogql): more functions #14969
Conversation
posthog/hogql/constants.py
Outdated
"toJSONString": ("toJSONString", 1, 1), | ||
"parseDateTime": ("parseDateTimeOrNull", 2, 2), | ||
"parseDateTimeBestEffort": ("parseDateTimeBestEffortOrNull", 2, 2), | ||
# dates and times TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also suggest adding today
, saw a user need it a couple weeks ago (toDate(now())
just doesn't roll of the tongue as well)
c12ca33
to
1dcf545
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Seems useful to check for the number of required args.
Changes
Adds JSON property accesssplit out to a different PR1 < 3 ? 'red' : 'green'
Stacked on top of #14968
How did you test this code?