Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lifecycle): Bring back date grouping #13398

Merged
merged 1 commit into from
Dec 19, 2022
Merged

fix(lifecycle): Bring back date grouping #13398

merged 1 commit into from
Dec 19, 2022

Conversation

neilkakkar
Copy link
Collaborator

Problem

Fixes #13355

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@neilkakkar neilkakkar marked this pull request as ready for review December 19, 2022 11:44
pauldambra
pauldambra approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked locally and does what it says on the tin

Happy to get this in to fix the bug. But we should add a visual regression test on this component now as a follow-up

@neilkakkar neilkakkar enabled auto-merge (squash) December 19, 2022 12:03
@neilkakkar neilkakkar merged commit cba25a9 into master Dec 19, 2022
@neilkakkar neilkakkar deleted the fix-lifecycle branch December 19, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

@mariusandra mariusandra Awaiting requested review from mariusandra

@thmsobrmlr thmsobrmlr Awaiting requested review from thmsobrmlr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

controls missing from insights
2 participants
@neilkakkar @pauldambra