Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update common-questions.mdx #8065

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Update common-questions.mdx #8065

merged 1 commit into from
Mar 18, 2024

Conversation

neilkakkar
Copy link
Contributor

Changes

Add clarification
Please describe.

Add screenshots or screen recordings for visual / UI-focused changes.

Checklist

  • Words are spelled using American English
  • Titles are in sentence case
  • Feature names are in sentence case too
  • Use relative URLs for internal links
  • If I moved a page, I added a redirect in vercel.json
  • Remove this template if you're not going to fill it out!

Article checklist

  • I've added (at least) 3-5 internal links to this new article
  • I've added keywords for this page to the rank tracker in Ahrefs
  • I've checked the preview build of the article
  • The date on the article is today's date
  • I've added this to the relevant "Tutorials and guides" docs page (if applicable)

Useful resources

@vercel Vercel
Copy link

vercel bot commented Mar 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Mar 18, 2024 0:08am

Lior539
Lior539 reviewed Mar 18, 2024
View reviewed changes
contents/docs/feature-flags/common-questions.mdx
@@ -34,6 +34,8 @@ If you're [identifying](/docs/product-analytics/identify) users, they may see a

To ensure they experience consistent behavior, check that you call `identify()` before evaluating the feature flag.

> *Note*: This does not apply to server-side SDKs, because you're explicitly telling us which distinct ID to use to evaluate flags, rather than depending on the identify() event to tell us which distinct ID to use.
Copy link
Contributor

@Lior539 Lior539 Mar 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> *Note*: This does not apply to server-side SDKs, because you're explicitly telling us which distinct ID to use to evaluate flags, rather than depending on the identify() event to tell us which distinct ID to use.
> *Note*: This only applies to frontend SDKs. Server-side SDKs do not need to call `identify()`.

camerondeleone
camerondeleone approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@camerondeleone camerondeleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

contents/docs/feature-flags/common-questions.mdx
@@ -34,6 +34,8 @@ If you're [identifying](/docs/product-analytics/identify) users, they may see a

To ensure they experience consistent behavior, check that you call `identify()` before evaluating the feature flag.

> *Note*: This does not apply to server-side SDKs, because you're explicitly telling us which distinct ID to use to evaluate flags, rather than depending on the identify() event to tell us which distinct ID to use.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would avoid stating the claim about identify on server so strongly for now @Lior539 because, while somewhat rare, we do explicitly tell users to call identify from the backend for a PoE v2 workaround (when signup event is on backend, not properly merged with anon frontend events unless identify is called on server...).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cameeron. My understanding is that the scenario you described above, they should use alias right? and not identify? (I know alias uses identify under the hood though).

I would avoid stating the claim about identify on server so strongly for now

This approach is also aligned with how we described it in the identify docs i.e. something you use on the frontend + we only show frontend code snippets

@camerondeleone camerondeleone merged commit 638be43 into master Mar 18, 2024
2 checks passed
@camerondeleone camerondeleone deleted the neilkakkar-patch-6 branch March 18, 2024 16:11
xrdt pushed a commit that referenced this pull request Mar 18, 2024
@neilkakkar
Update common-questions.mdx (#8065)
6b63f9f
xrdt added a commit that referenced this pull request Mar 18, 2024
@xrdt @raquelmsmith
@Lior539 @marandaneto @smallbrownbike @corywatilo @simfish85 @joethreepwood @neilkakkar @jtemperton @andyvan-ph @benjackwhite @a20hek @charlescook-ph
feat: Cap pa calculator at 250 million events, show contact us on pri…
55f98cb 
…cing table (#8033)

* cap pa calculator at 250 million events

* add some missing pieces

* Update package.json

Co-authored-by: Raquel Smith <[email protected]>

* remove pricing control (#8037)

* add ai template (#8041)

* fix: update 15k free recordings to 5k (#8040)

* New roadmap pages (#8045)

* WIP page

* add team update form to team pages

* add update on wip page

* add option to post as team lead

* only show relevant team roadmap items

* refresh roadmaps on team change

* allow editing updates

* show author info / link to teams

* show in progress roadmap items on WIP page

* roadmap changes

* unlogged in auth

* small polish

* sort

* update/add items

* link

* update schema

* polish

* team names

* sidebars

* type to search

* fix import

* dark

* spacing

* polished roadmap page

* polished roadmap, wip forms

* updated changelog edit ui to match

* v small cleanup

---------

Co-authored-by: Cory Watilo <[email protected]>

* Small quality fixes (#8052)

* active tab fix

* fix back to links

* Roadmap cleanup (#8053)

* sizing/spacing

* move/style edit buttons

* consistent header sizes

* updated WIP subscribe icons

* Added support gating to historic data import pages (#8030)

* Added support gating to historic data import pages

* Update contents/docs/migrate/ingest-historic-data.mdx

Co-authored-by: Joe Martin <[email protected]>

* Update contents/docs/migrate/migrate-from-amplitude.mdx

Co-authored-by: Joe Martin <[email protected]>

* Update contents/docs/migrate/migrate-to-cloud.mdx

Co-authored-by: Joe Martin <[email protected]>

* Update contents/docs/migrate/ingest-historic-data.mdx

Co-authored-by: Joe Martin <[email protected]>

* Update contents/docs/migrate/migrate-from-amplitude.mdx

Co-authored-by: Joe Martin <[email protected]>

* Update contents/docs/migrate/ingest-historic-data.mdx

Co-authored-by: Joe Martin <[email protected]>

* Update contents/docs/migrate/migrate-from-amplitude.mdx

Co-authored-by: Joe Martin <[email protected]>

* Update contents/docs/migrate/ingest-historic-data.mdx

Co-authored-by: Joe Martin <[email protected]>

* Update contents/docs/migrate/migrate-to-cloud.mdx

Co-authored-by: Joe Martin <[email protected]>

* Update contents/docs/migrate/migrate-from-amplitude.mdx

Co-authored-by: Joe Martin <[email protected]>

---------

Co-authored-by: Joe Martin <[email protected]>

* Adding DigitalOcean to PostHog for Startups (#7997)

* Adding DigitalOcean to PostHog for Startups

* Update contents/startups.mdx

* Update contents/startups.mdx

* Apply suggestions from code review

* Apply suggestions from code review

* Add Go ticker option (#8044)

* Add Go ticker option

* Update contents/docs/feature-flags/local-evaluation.mdx

* add link (#8057)

* Light edits to the company handbook (#8047)

* light edits to the company handbook

tagging in @andyvan-ph to look these over first up. Most changes are pretty minor, couple of bigger edits on sentences that were tricky to parse

* Apply suggestions from code review

Co-authored-by: Andy Vandervell <[email protected]>

* Update current-status.md

---------

Co-authored-by: Andy Vandervell <[email protected]>

* Clarified PostHog cookie name (#8060)

* chore: Update RN docs for v3 initialization (#7902)

* Renamed v3 js-lite methods (#8021)

* docs: fix typo in `nextjs-analytics.md` (#8035)

* Ruby add flag timeouts (#8058)

* Ruby add flag timeouts

* Apply suggestions from code review

* lior: add request timeouts to other docs

---------

Co-authored-by: Lior <[email protected]>

* chore: document opt_out_persistence_by_default (#8025)

* chore: add session recording section on flutter docs (#8066)

* fix: code snippets for node and rn v3 and v4 (#8068)

* Bunch of CS updates to the Handbook (#8055)

* Update overview.md

* Update index.js

* Update index.mdx

* Update mission.mdx

* Update overview.md

* Update contents/teams/customer-success/index.mdx

Co-authored-by: Simon Fisher <[email protected]>

---------

Co-authored-by: Simon Fisher <[email protected]>

* Web analytics product page (#8001)

* web analytics screenshots, hero copy

* PostHog Vs content

* Update index.tsx

* Added some generic tutorials

* Pairs with

* web analytics topic

* comparison chart

* new tutorial

* Update index.tsx

* Subfeatures - words, not icons

* Merge branch 'master' into web-analytics

* removed unused sections, added icons, linked to page

* open graph

* fixed "posthog vs" mobile padding when in wide mode

* beta flag

* added line about pricing

* clarified how web analytics is billed

---------

Co-authored-by: Joe Martin <[email protected]>

* Update common-questions.mdx (#8065)

* address pr feedback

* fix up the link

---------

Co-authored-by: Raquel Smith <[email protected]>
Co-authored-by: Lior539 <[email protected]>
Co-authored-by: Manoel Aranda Neto <[email protected]>
Co-authored-by: Eli Kinsey <[email protected]>
Co-authored-by: Cory Watilo <[email protected]>
Co-authored-by: Cory Watilo <[email protected]>
Co-authored-by: Simon Fisher <[email protected]>
Co-authored-by: Joe Martin <[email protected]>
Co-authored-by: Neil Kakkar <[email protected]>
Co-authored-by: James Temperton <[email protected]>
Co-authored-by: Andy Vandervell <[email protected]>
Co-authored-by: Ben White <[email protected]>
Co-authored-by: Abhishek Ajithkumar <[email protected]>
Co-authored-by: Charles Cook <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lior539 Lior539 Lior539 approved these changes

@camerondeleone camerondeleone camerondeleone approved these changes

@jurajmajerik jurajmajerik Awaiting requested review from jurajmajerik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neilkakkar @Lior539 @camerondeleone