Add UUID to events, based on Segment's messageId #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretthoerner
force-pushed
the
brett/uuid
branch
2 times, most recently
from
9265f5d to
d8b2e48
Compare
bretthoerner
force-pushed
the
brett/uuid
branch
from
d8b2e48 to
fc880d7
Compare
bretthoerner
commented
Apr 29, 2024
| @@ -45,6 +45,9 @@ async function onTrack(event, settings) { | |||
| const endpoint = new URL(`${baseUrl}/capture/`) | |||
| endpoint.searchParams.set('ts', event.timestamp) | |||
|
|
|||
| const namespace = uuidv5.uuidv5('null', 'PostHog', true) | |||
| const uuid = uuidv5.uuidv5(namespace, event.messageId) | |||
There was a problem hiding this comment.
uuidv5 docs show this example for making a custom namespace: https://www.npmjs.com/package/uuidv5
(I don't think it's worth worrying about whether we can cache in global state or anything like that...)
tkaemming
approved these changes
Apr 30, 2024
xvello
approved these changes
Apr 30, 2024
Can you verify 99c7c66 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal context: https://posthoghelp.zendesk.com/agent/tickets/12556
Segment documentation about
uuidv5.uuidv5being available: https://segment.com/docs/connections/functions/destination-functions/#runtime-and-dependenciesWe are using their
messageIdto generate a UUID to remove duplicates.The repo says to ping Tim for updates. He (or whoever can) should probably run this against real test data inside of Segment's app. It seems like they have a nice interface in there for testing this out?