Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added generic properties and bumped version to 0.2.0 #1

Merged
merged 4 commits into from
Jun 25, 2022

Conversation

christos-h
Copy link
Contributor

@christos-h christos-h commented Oct 21, 2021

I created this PR as I need support for nested hierarchical data in the properties and not just string kv pairs.

I bumped the minor version since this breaks our first experimental API (fields are no longer public).

Hopefully we can get this merged ASAP and I'll push to crates.io because we need this dependency in the Synth project.

@christos-h
Copy link
Contributor Author

@fuziontech are you the maintainer of this repository?

@fuziontech
Copy link
Member

Hey @christoshadjiaslanis - Not officially, but I'm happy to get this in. Looks good and tests pass. I'll get this in now. 🚢

Copy link
Member

@fuziontech fuziontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and tests ✅

@fuziontech fuziontech merged commit 9253626 into PostHog:main Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants