Polish the plugin a bit #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have a look here: PostHog/plugin-server#17 (comment) I think this is epic, but we should make most of the tests/ code changes in |
|
That makes sense, I'll basically take this PR to the actual Hello World plugin then. |
|
Yep, sounds perfect! |
This was referenced Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a README update. Also switched recommended package manager to npm from yarn, since the latter can be confusing for people who don't do JS a lot (as in everyone has npm after installing Node, but yarn requires installation with npm, which raises questions).
Added an exemplary logo file to "show, don't tell".