feat: pnpm patch rrweb #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
approved these changes
Jan 26, 2024
pauldambra
force-pushed
the
feat/pnpm-patch-rrweb
branch
from
d414ec5
to
9e5b8f1
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stacked on top of #970
once we've moved to pnpm
we can use pnpm patch
we have had customer reports of
processMutationsfreezing their siterrweb-io/rrweb#1321 is an improvement to that flow, but unreleased so far
let's patch it in and see if it helps, since it processes the DOM far fewer times it should help in any cases where the DOM is complex enough that the constant rescan is expensive