chore: convert more tests to TS #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 739 kB ℹ️ View Unchanged
|
pauldambra
commented
Nov 19, 2023
| @@ -42,11 +100,11 @@ describe('Autocapture system', () => { | |||
| sensitiveInput.value = 'test val' | |||
| sensitiveInput.className = 'ph-sensitive' | |||
|
|
|||
| hidden = document.createElement('div') | |||
| hidden = document.createElement('input') | |||
There was a problem hiding this comment.
JS didn't care that we were hammering input props into a div
pauldambra
commented
Nov 19, 2023
| hidden.setAttribute('type', 'hidden') | ||
| hidden.value = 'hidden val' | ||
|
|
||
| password = document.createElement('div') | ||
| password = document.createElement('input') |
There was a problem hiding this comment.
JS didn't care that we were hammering input props into a div
pauldambra
commented
Nov 19, 2023
| @@ -160,12 +224,12 @@ describe('Autocapture system', () => { | |||
| sensitiveInput.setAttribute('data-ph-capture-attribute-on-the-sensitive-input', 'is on the sensitive-input') | |||
| sensitiveInput.className = 'ph-sensitive' | |||
|
|
|||
| hidden = document.createElement('div') | |||
| hidden = document.createElement('input') | |||
There was a problem hiding this comment.
JS didn't care that we were hammering input props into a div
pauldambra
commented
Nov 19, 2023
| hidden.setAttribute('type', 'hidden') | ||
| hidden.setAttribute('data-ph-capture-attribute-on-the-hidden', 'is on the hidden') | ||
| hidden.value = 'hidden val' | ||
|
|
||
| password = document.createElement('div') | ||
| password = document.createElement('input') |
There was a problem hiding this comment.
JS didn't care that we were hammering input props into a div
pauldambra
commented
Nov 19, 2023
Comment on lines
+269
to
279
| it('should not collect augment from the hidden element value', () => { | ||
| const props = autocapture._getAugmentPropertiesFromElement(hidden) | ||
| expect(props['on-the-hidden']).toBe('is on the hidden') | ||
| expect(props).toStrictEqual({}) | ||
| }) | ||
|
|
||
| it('should collect augment from the password element value', () => { | ||
| const props = autocapture._getAugmentPropertiesFromElement(password) | ||
| expect(props['on-the-password']).toBe('is on the password') | ||
| expect(props).toStrictEqual({}) | ||
| }) | ||
| }) | ||
|
|
There was a problem hiding this comment.
These tests were wrong because we were setting input properties on a div, we shouldn't be capturing anything on hidden and password inputs. It behaves correctly, just the tests were confused
benjackwhite
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:I've started so I'll finish:.meme
Keep converting tests to TypeScript.