Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocapture): element properties tracked up to 1k bytes #783

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

mariusandra
Copy link
Collaborator

Changes

Element properties might accidentally capture hundreds of kilobytes of data as their values.

Limits each property to 1kb.

Internal context: https://posthog.slack.com/archives/C05N3FJ1P43/p1692976658788549?thread_ts=1692955596.324029&cid=C05N3FJ1P43

Checklist

@mariusandra mariusandra requested review from tiina303 and xvello August 25, 2023 15:29
@github-actions
Copy link

Size Change: +348 B (0%)

Total Size: 676 kB

Filename Size Change
dist/array.full.js 175 kB +87 B (0%)
dist/array.js 117 kB +87 B (0%)
dist/es.js 116 kB +87 B (0%)
dist/module.js 117 kB +87 B (0%)
ℹ️ View Unchanged
Filename Size
dist/recorder-v2.js 93.6 kB
dist/recorder.js 58.3 kB

compressed-size-action

@timgl timgl added the bump patch Bump patch version when this PR gets merged label Aug 25, 2023
@timgl timgl merged commit 74a7d37 into master Aug 25, 2023
@timgl timgl deleted the element-property-length branch August 25, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants