feat: Add pathname to prev page events #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-c
changed the title
|
Size Change: +629 B (0%) Total Size: 676 kB
ℹ️ View Unchanged
|
benjackwhite
approved these changes
Aug 18, 2023
src/page-view.ts
Outdated
| export class PageViewManager { | ||
| _pageViewData: PageViewData | undefined | ||
| _hasSeenPageView = false | ||
|
|
||
| _createPageViewData(): PageViewData { | ||
| return {} | ||
| return { | ||
| pathname: utils.window.location.pathname, |
There was a problem hiding this comment.
I assume we need this to query on? Do we perhaps want to just have a full url which allows any kind of grouping filtering later on?
2 tasks
|
|
Twixes
approved these changes
Aug 21, 2023
| @@ -24,15 +25,21 @@ interface ScrollProperties { | |||
| $prev_pageview_max_content_percentage?: number | |||
| } | |||
|
|
|||
| interface PageViewEventProperties extends ScrollProperties { | |||
| $prev_pageview_pathname?: string | |||
There was a problem hiding this comment.
We might want to update isURLNormalizeable() in the main repo to include this property
robbie-c
force-pushed
the
add-pathname-to-prev-page-properties
branch
from
b602a53 to
0d75918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow up from #773, looks like I did need this
Checklist