-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove lz compression #654
Conversation
Size Change: -19 kB (-1%) Total Size: 2.33 MB
ℹ️ View Unchanged
|
With two days of data searched using Also a query like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it
We've wanted to remove LZ compression for c2 years. #155
it is 5%+ of the bundle size.
Let's remove it
Needs data from PostHog/posthog#15765 to confirm that we don't receive LZ compressed traffic (a quick check of 1 day of nginx logs suggested we don't)
compression options are provided by decide, decide returns a harcoded list, and the library prefers gzip if it is present. So this can only negatively affect people using very, very old self-hosted versions and the latest pothog-js. And even then it would mean they would switch from lz64 to base64 so things would carry on working.