-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use rollup and fix define module issues #434
Conversation
I fixed what was broken and changed the export type to There's no possible conflict with a global We went down some bytes in size as well! 114k -> 79k, a 30% reduction!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks sensible to me!
Nice! Do you feel confident releasing this as is, or should we do some testing somehow? |
Just to be sure, I built, published and tested the new array.js locally on kea-docs, and everything worked. Events came in, sessions got recorded. The github test with IE11 even passes. Thus yep, let's release and get it on cloud for further testing. |
Changes
In progress. Only thing missing is minification of dist/array.js which I couldn't figure out with rollup
Checklist