Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use previous site-app variables #1574

Merged
merged 2 commits into from
Dec 2, 2024
Merged

fix: use previous site-app variables #1574

merged 2 commits into from
Dec 2, 2024

Conversation

mariusandra
Copy link
Collaborator

Changes

The existing site apps on cloud expect __$$ph_site_app_${id} as the global where they'll find the PostHog-JS library. This changed recently to __$$ph_site_app_${id}_posthog. Revert that change.

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@mariusandra mariusandra added the bump patch Bump patch version when this PR gets merged label Dec 2, 2024
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Dec 2, 2024 2:29pm

Copy link

github-actions bot commented Dec 2, 2024

Size Change: -110 B (0%)

Total Size: 3.18 MB

Filename Size Change
dist/array.full.es5.js 258 kB -11 B (0%)
dist/array.full.js 361 kB -11 B (0%)
dist/array.full.no-external.js 360 kB -11 B (0%)
dist/array.js 175 kB -11 B (-0.01%)
dist/array.no-external.js 174 kB -11 B (-0.01%)
dist/main.js 176 kB -11 B (-0.01%)
dist/module.full.js 361 kB -11 B (0%)
dist/module.full.no-external.js 360 kB -11 B (0%)
dist/module.js 175 kB -11 B (-0.01%)
dist/module.no-external.js 174 kB -11 B (-0.01%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/customizations.full.js 12.5 kB
dist/dead-clicks-autocapture.js 14.3 kB
dist/exception-autocapture.js 9.37 kB
dist/external-scripts-loader.js 2.29 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.2 kB
dist/tracing-headers.js 1.75 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@mariusandra mariusandra merged commit e2689c0 into main Dec 2, 2024
13 checks passed
@mariusandra mariusandra deleted the use-old-posthog-var branch December 2, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants