fix: infinite loop when combining controls #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pauldambra
commented
Nov 28, 2024
Comment on lines
+395
to
+397
| if (this._urlBlocked) { | ||
| return 'paused' | ||
| } |
There was a problem hiding this comment.
the fix is to have this as the (almost) earliest check in status
rrweb continues to emit, because it doesn't know that it is paused
and we continue to check
until the URL changes and we resume
pauldambra
commented
Nov 28, 2024
| @@ -501,13 +501,15 @@ export class SessionRecording { | |||
| if (isNullish(this._removePageViewCaptureHook)) { | |||
| // :TRICKY: rrweb does not capture navigation within SPA-s, so hook into our $pageview events to get access to all events. | |||
| // Dropping the initial event is fine (it's always captured by rrweb). | |||
| this._removePageViewCaptureHook = this.instance._addCaptureHook((eventName) => { | |||
| this._removePageViewCaptureHook = this.instance.on('eventCaptured', (event) => { | |||
There was a problem hiding this comment.
changed this to not rely on a semi private method
pauldambra
commented
Nov 28, 2024
Comment on lines
509
to
512
| const href = event?.properties.$current_url | ||
| ? this._maskUrl(event?.properties.$current_url) | ||
| : '' | ||
| if (!href || this.status !== 'active') { |
There was a problem hiding this comment.
pageview already tells you what URL it is, so we don't need to ask the window
There was a problem hiding this comment.
fly by change that had been annoying me
|
Size Change: +662 B (+0.02%) Total Size: 3.18 MB
ℹ️ View Unchanged
|
marandaneto
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://posthoghelp.zendesk.com/agent/tickets/21246
When waiting for a linked flag to activate recordings, and also pausing on URL, the browser could get stuck in a loop trying to emit a custom event that it had paused when it had not yet started,
so the note it emitted triggered the pause check which again tried to pause
which caused a custom event
etc