Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch errors detecting dialog state when recording #1562

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

pauldambra
Copy link
Member

see #1561 which points at an error in using the :modal pseudo selector

it does appear that safari started supporting the dialog element in 15.4 and the :modal selector in 15.6

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Nov 27, 2024 10:25am

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Nov 27, 2024
@pauldambra pauldambra requested review from a team and daibhin November 27, 2024 10:28
Copy link

Size Change: +490 B (+0.02%)

Total Size: 3.15 MB

Filename Size Change
dist/all-external-dependencies.js 206 kB +70 B (+0.03%)
dist/array.full.js 358 kB +70 B (+0.02%)
dist/array.full.no-external.js 357 kB +70 B (+0.02%)
dist/module.full.js 358 kB +70 B (+0.02%)
dist/module.full.no-external.js 357 kB +70 B (+0.02%)
dist/recorder-v2.js 115 kB +70 B (+0.06%)
dist/recorder.js 115 kB +70 B (+0.06%)
ℹ️ View Unchanged
Filename Size
dist/array.full.es5.js 255 kB
dist/array.js 172 kB
dist/array.no-external.js 171 kB
dist/customizations.full.js 12.1 kB
dist/dead-clicks-autocapture.js 14.3 kB
dist/exception-autocapture.js 9.37 kB
dist/external-scripts-loader.js 2.29 kB
dist/main.js 173 kB
dist/module.js 173 kB
dist/module.no-external.js 171 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.2 kB
dist/tracing-headers.js 1.75 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

Copy link
Contributor

@rafaeelaudibert rafaeelaudibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@pauldambra pauldambra merged commit 0ac5571 into main Nov 27, 2024
17 checks passed
@pauldambra pauldambra deleted the fix/pd/modal-support branch November 27, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants