Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve ES6 bundling #1542

Merged
merged 9 commits into from
Nov 20, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Nov 19, 2024

#1525 - IE 11 tests are freezing in that PR and it's really hard to figure out why

have pulled many small changes out of that PR but the IE 11 tests still freeze


  • improves detection/bundling of ES6 support for posthog-js by being more specific with the browser targets that are passed to the bundler
  • adds a check that the array.full.js is ES6 compliant in CI

Does not update the browserslist value in package.json, since that is the change that appears to make CI freeze
I'd rather get the benefit of the ES6 compliant bundle in prod before fixing that

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Nov 20, 2024 8:20am

Copy link

github-actions bot commented Nov 19, 2024

Size Change: +16.6 kB (+0.53%)

Total Size: 3.14 MB

Filename Size Change
dist/all-external-dependencies.js 206 kB +1.44 kB (+0.7%)
dist/array.full.js 358 kB +1.24 kB (+0.35%)
dist/array.full.no-external.js 357 kB +1.21 kB (+0.34%)
dist/array.js 172 kB +907 B (+0.53%)
dist/array.no-external.js 171 kB +816 B (+0.48%)
dist/dead-clicks-autocapture.js 14.3 kB +699 B (+5.12%) 🔍
dist/exception-autocapture.js 9.36 kB +657 B (+7.55%) 🔍
dist/external-scripts-loader.js 2.29 kB +22 B (+0.97%)
dist/main.js 173 kB +923 B (+0.54%)
dist/module.full.js 358 kB +1.24 kB (+0.35%)
dist/module.full.no-external.js 357 kB +1.21 kB (+0.34%)
dist/module.js 172 kB +1 kB (+0.59%)
dist/module.no-external.js 171 kB +836 B (+0.49%)
dist/recorder-v2.js 115 kB +1.06 kB (+0.94%)
dist/recorder.js 115 kB +1.06 kB (+0.94%)
dist/surveys-preview.js 57.6 kB +907 B (+1.6%)
dist/surveys.js 63.2 kB +1.02 kB (+1.64%)
dist/tracing-headers.js 1.75 kB +348 B (+24.8%) 🚨
dist/web-vitals.js 10.3 kB -8 B (-0.08%)
ℹ️ View Unchanged
Filename Size
dist/array.full.es5.js 254 kB

compressed-size-action

@pauldambra pauldambra changed the title fix: remove ie11 from main supported browsers fix: improve ES6 bundling Nov 20, 2024
@pauldambra pauldambra requested review from robbie-c and a team November 20, 2024 08:24
@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Nov 20, 2024
Copy link
Member

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low context n. N :D

@pauldambra pauldambra merged commit 4f1a2bc into main Nov 20, 2024
18 checks passed
@pauldambra pauldambra deleted the fix/remove-ie11-from-main-supported-browsers branch November 20, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants