feat: deadclicks in heatmaps #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +4.78 kB (+0.16%) Total Size: 3.01 MB
ℹ️ View Unchanged
|
pauldambra
commented
Nov 5, 2024
pauldambra
commented
Nov 8, 2024
|
|
||
| export function isElementInToolbar(el: Element): boolean { | ||
| // NOTE: .closest is not supported in IE11 hence the operator check | ||
| return el.id === TOOLBAR_ID || !!el.closest?.('#' + TOOLBAR_ID) |
There was a problem hiding this comment.
this was only working previously by accident because there is also ph-no-capture which autocapture obeys
closest does not escape shadow roots and TOOLBAR_ID is outside the shadow root.
switched to a selector inside the shadow root (the selector provided is at the root of the toolbar inside the shadow root
e.g.
<div id="TOOLBAR_ID">
<shadow_root>
<div class=TOOLBAR_CONTAINER_CLASS>
richard-better
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we want to allow deadclicks collection in heatmaps
it gives you less information but doesn't cost money, folk that want more information can turn on standalone deadclicks capture
to keep things loose the heatmap starts its own instance of deadclicks capture, deadclicks was altered to receive varying behviour by constructor injection
running locally I can capture deadclicks correctly with both deadclicks and heatmaps enabled or either one enabled