Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not capture entire elements in web vitals #1483

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

pauldambra
Copy link
Member

see https://posthoghelp.zendesk.com/agent/tickets/19253

we capture INP attribution to help with debugging but that includes a reference to a DOM element

they can be very large or painful to serialize

we could run through autocapture to get elements chain but until #1463 that code isn't accessible easily for arbitrary elements

so for now, to resolve the issue, let's just drop the unusable property

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Oct 17, 2024 9:52pm

@pauldambra pauldambra requested a review from a team October 17, 2024 21:33
@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Oct 17, 2024
Copy link

Size Change: +1.03 kB (+0.04%)

Total Size: 2.82 MB

Filename Size Change
dist/array.full.es5.js 248 kB +103 B (+0.04%)
dist/array.full.js 325 kB +103 B (+0.03%)
dist/array.full.no-external.js 324 kB +103 B (+0.03%)
dist/array.js 155 kB +103 B (+0.07%)
dist/array.no-external.js 154 kB +103 B (+0.07%)
dist/main.js 156 kB +103 B (+0.07%)
dist/module.full.js 325 kB +103 B (+0.03%)
dist/module.full.no-external.js 324 kB +103 B (+0.03%)
dist/module.js 155 kB +103 B (+0.07%)
dist/module.no-external.js 154 kB +103 B (+0.07%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 172 kB
dist/exception-autocapture.js 8.75 kB
dist/external-scripts-loader.js 2.19 kB
dist/recorder-v2.js 92.6 kB
dist/recorder.js 92.7 kB
dist/surveys-preview.js 56.7 kB
dist/surveys.js 62.1 kB
dist/tracing-headers.js 1.33 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@pauldambra pauldambra merged commit d01ad73 into main Oct 18, 2024
17 checks passed
@pauldambra pauldambra deleted the fix/do-not-capture-entire-elements branch October 18, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants