Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-analytics): Store nulls for unset campaign params #1482

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Oct 17, 2024

Changes

Send null for all the campaign params that are not set, rather than leaving them unset and potentially overridden later. Fixes PostHog/posthog#7710

I looked at doing this during ingestion, these PRs PostHog/posthog#25132 PostHog/posthog#25135 do this but it seems like we don't want to touch person processing code too much this quarter

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Oct 17, 2024 11:28am

@posthog-bot
Copy link
Collaborator

Hey @robbie-c! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

Copy link

Size Change: +9 B (0%)

Total Size: 2.85 MB

Filename Size Change
dist/array.full.js 357 kB +1 B (0%)
dist/array.full.no-external.js 356 kB +1 B (0%)
dist/array.js 171 kB +1 B (0%)
dist/array.no-external.js 170 kB +1 B (0%)
dist/main.js 172 kB +1 B (0%)
dist/module.full.js 357 kB +1 B (0%)
dist/module.full.no-external.js 356 kB +1 B (0%)
dist/module.js 171 kB +1 B (0%)
dist/module.no-external.js 170 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 192 kB
dist/exception-autocapture.js 11.3 kB
dist/external-scripts-loader.js 2.35 kB
dist/recorder-v2.js 111 kB
dist/recorder.js 111 kB
dist/surveys-preview.js 59.8 kB
dist/surveys.js 66 kB
dist/tracing-headers.js 8.36 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@robbie-c robbie-c added the bump minor Bump minor version when this PR gets merged label Oct 17, 2024
@robbie-c robbie-c merged commit 6bb798f into main Oct 17, 2024
22 checks passed
@robbie-c robbie-c deleted the feature/store-nulls-for-unset-campaign-params branch October 17, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utm properties get set on later visits but likely shouldn't
3 participants