Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move @types/web to dev dependencies #1367

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Aug 19, 2024

Changes

Move @types/web to dev dependencies

See #1366

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Aug 19, 2024 2:45pm

@robbie-c robbie-c changed the title Move @types/web to dev dependencies fix: Move @types/web to dev dependencies Aug 19, 2024
@robbie-c robbie-c added the bump patch Bump patch version when this PR gets merged label Aug 19, 2024
@robbie-c robbie-c requested a review from marandaneto August 19, 2024 14:45
Copy link

Size Change: 0 B

Total Size: 1.17 MB

ℹ️ View Unchanged
Filename Size
dist/array.full.js 333 kB
dist/array.js 154 kB
dist/exception-autocapture.js 10.4 kB
dist/main.js 155 kB
dist/module.js 154 kB
dist/recorder-v2.js 110 kB
dist/recorder.js 110 kB
dist/surveys-preview.js 59.8 kB
dist/surveys.js 66 kB
dist/tracing-headers.js 8.26 kB
dist/web-vitals.js 5.79 kB

compressed-size-action

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robbie-c robbie-c merged commit 2ba735b into main Aug 19, 2024
17 checks passed
@robbie-c robbie-c deleted the fix/move-types-web-to-dev-deps branch August 19, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants