Fixes

src/__tests__/decide.ts

@@ -57,6 +57,8 @@ describe('Decide', () => {
             get_distinct_id: jest.fn().mockImplementation(() => 'distinctid'),
             _send_request: jest.fn().mockImplementation(({ callback }) => callback?.({ config: {} })),
             featureFlags: {
+                resetRequestQueue: jest.fn(),
+                reloadFeatureFlags: jest.fn(),
                 receivedFeatureFlags: jest.fn(),
                 setReloadingPaused: jest.fn(),
                 _startReloadTimer: jest.fn(),
@@ -305,5 +307,20 @@ describe('Decide', () => {
             })
             expect(posthog._onRemoteConfig).toHaveBeenCalledWith(config)
         })
+
+        it.each([
+            [true, true],
+            [false, false],
+            [undefined, true],
+        ])('conditionally reloads feature flags - hasFlags: %s, shouldReload: %s', (hasFeatureFlags, shouldReload) => {
+            assignableWindow._POSTHOG_CONFIG = { hasFeatureFlags } as RemoteConfig
+            decide().call()
+
+            if (shouldReload) {
+                expect(posthog.featureFlags.reloadFeatureFlags).toHaveBeenCalled()
+            } else {
+                expect(posthog.featureFlags.reloadFeatureFlags).not.toHaveBeenCalled()
+            }
+        })
     })
 })

src/decide.ts

@@ -43,6 +43,17 @@ export class Decide {
     }
 
     call(): void {
+        // Call decide to get what features are enabled and other settings.
+        // As a reminder, if the /decide endpoint is disabled, feature flags, toolbar, session recording, autocapture,
+        // and compression will not be available.
+        const disableRemoteCalls = !!this.instance.config.advanced_disable_decide
+
+        if (!disableRemoteCalls) {
+            // TRICKY: Reset any decide reloads queued during config.loaded because they'll be
+            // covered by the decide call right above.
+            this.instance.featureFlags.resetRequestQueue()
+        }
+
         if (this.instance.config.__preview_remote_config) {
             // Attempt 1 - use the pre-loaded config if it came as part of the token-specific array.js
             if (assignableWindow._POSTHOG_CONFIG) {
@@ -51,6 +62,11 @@ export class Decide {
                 return
             }
 
+            if (disableRemoteCalls) {
+                logger.warn('Remote config is disabled. Falling back to local config.')
+                return
+            }
+
             // Attempt 2 - if we have the external deps loader then lets load the script version of the config that includes site apps
             this._loadRemoteConfigJs((config) => {
                 if (!config) {
@@ -138,6 +154,10 @@ export class Decide {
 
         this.instance._onRemoteConfig(config)
 
-        // Additionally trigger loading of flags if necessary
+        if (config.hasFeatureFlags !== false) {
+            // If the config has feature flags, we need to call decide to get the feature flags
+            // This completely separates it from the config logic which is good in terms of separation of concerns
+            this.instance.featureFlags.reloadFeatureFlags()
+        }
     }
 }

src/posthog-core.ts

@@ -610,16 +610,7 @@ export class PostHog {
             }, 1)
         }
 
-        // Call decide to get what features are enabled and other settings.
-        // As a reminder, if the /decide endpoint is disabled, feature flags, toolbar, session recording, autocapture,
-        // and compression will not be available.
-        if (!disableDecide) {
-            new Decide(this).call()
-
-            // TRICKY: Reset any decide reloads queued during config.loaded because they'll be
-            // covered by the decide call right above.
-            this.featureFlags.resetRequestQueue()
-        }
+        new Decide(this).call()
     }
 
     _start_queue_if_opted_in(): void {