Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with iOS SDK v2 #83

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Compatibility with iOS SDK v2 #83

merged 3 commits into from
Oct 30, 2023

Conversation

marandaneto
Copy link
Member

What does this PR do?

Compatibility with iOS SDK v2, move the old queue to the new queue and delete the old files

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

The iOS SDK previously didn't support multiple SDKs running at the same time since there's no apiKey or tag within the caching path (well they would share the same folder and it'd be a mess).
If we want to add support for it, we can make it in another PR, but I'd not block the first release because of that since there's no support already.

What are the relevant tickets?

Screenshots or screencasts (if UI/UX change)

Questions:

  • Does the docs need an update?
  • Are there any security concerns?
  • Do we need to update engineering / success?

@marandaneto marandaneto marked this pull request as ready for review October 27, 2023 07:44
Copy link
Collaborator

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as it looks like it likely works, just a suggestion left

PostHog/PostHogQueue.swift Show resolved Hide resolved
@marandaneto marandaneto merged commit 6c8d69d into v3.0.0 Oct 30, 2023
1 of 2 checks passed
@marandaneto marandaneto deleted the chore/compatibility-v2 branch October 30, 2023 09:33
@marandaneto marandaneto mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants