Add ObjC example and add method annotations #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Oct 24, 2023
marandaneto
commented
Oct 24, 2023
marandaneto
commented
Oct 24, 2023
| @@ -363,7 +425,7 @@ let maxRetryDelay = 30.0 | |||
| return mergedGroups ?? [:] | |||
| } | |||
|
|
|||
| @objc public func groupIdentify(type: String, key: String, groupProperties: [String: Any]? = nil) { | |||
| private func groupIdentify(type: String, key: String, groupProperties: [String: Any]? = nil) { | |||
There was a problem hiding this comment.
I'd rather keep it as a group only as the other SDKs.
benjackwhite
requested changes
Oct 24, 2023
4 tasks
benjackwhite
approved these changes
Oct 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add ObjC example and add method annotations
Otherwise ObjC calls would be super long and repetitive.
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots or screencasts (if UI/UX change)
Questions: