Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mask swiftui picker if masking enabled #184

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Sep 6, 2024

💡 Motivation and Context

I took another stab at #163, and #167, and could not find a way to do this.
SwiftUI compiles a Text into an Image of the very same type (and many other types), so it's not possible to know if its one or the other.
SwiftUI discards all the accessibility tags during compilation
Meanwhile, I found a bug and made a few improvements.

💚 How did you test it?

Running a sample app with each type

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto marked this pull request as ready for review September 6, 2024 12:08
@marandaneto marandaneto requested a review from a team September 6, 2024 12:08
@marandaneto marandaneto merged commit ac6d287 into main Sep 6, 2024
8 checks passed
@marandaneto marandaneto deleted the fix/mask-picker branch September 6, 2024 13:21
Copy link

github-actions bot commented Sep 6, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Next" section. Make sure the entry includes this PR's number.
Example:

## Next
- mask swiftui picker if masking enabled ([#184](https://github.com/PostHog/posthog-ios/pull/184))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 01d95ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants