Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: recording network requests #125

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Mar 26, 2024

💡 Motivation and Context

example https://us.posthog.com/project/41706/replay/53D14CAB-D098-48E5-A995-A8670AE0FE3A

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

Copy link

github-actions bot commented Mar 26, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Next" section. Make sure the entry includes this PR's number.
Example:

## Next
- recording network requests ([#125](https://github.com/PostHog/posthog-ios/pull/125))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 8ad5d71

@marandaneto marandaneto changed the title chore: session replay chore: recording network requests Mar 26, 2024
@marandaneto marandaneto requested a review from pauldambra March 26, 2024 15:05
@@ -29,7 +29,7 @@ import Foundation
// if a view is being dismissed, this will return nil
if let root = viewIfLoaded?.window?.rootViewController {
return root
} else if #available(iOS 13.0, *) {
} else {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK is supported iOS >= 13 already

@marandaneto marandaneto marked this pull request as ready for review March 26, 2024 15:44
@marandaneto marandaneto merged commit 87a6bad into chore/session-replay Mar 27, 2024
4 of 6 checks passed
@marandaneto marandaneto deleted the chore/network-requests branch March 27, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant