Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: read $app_name from CFBundleDisplayName as a fallback if CFBundleName isn't available #108

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

marandaneto
Copy link
Member

💡 Motivation and Context

Closes #92

💚 How did you test it?

both are always xctest because it comes from the test runner, test already exists.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto changed the title read app name from bundle display name as a fallback if bundle name isnt available chore: read $app_name from CFBundleDisplayName as a fallback if CFBundleName isn't available Feb 19, 2024
@marandaneto marandaneto requested a review from a team February 19, 2024 12:35
@marandaneto marandaneto merged commit 504d5da into main Feb 19, 2024
7 checks passed
@marandaneto marandaneto deleted the chore/bundledisplayname branch February 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If kCFBundleNameKey isn't set, fallback to CFBundleDisplayName
2 participants