Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set network carrier if empty #66

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Do not set network carrier if empty #66

merged 2 commits into from
Nov 14, 2023

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Nov 14, 2023 •
edited
Loading

💡 Motivation and Context

Screenshot 2023-11-14 at 15 34 01

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

pauldambra
pauldambra approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marandaneto marandaneto merged commit d812492 into main Nov 14, 2023
5 checks passed
@marandaneto marandaneto deleted the fix/empty_carrier branch November 14, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @pauldambra