Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep trying to flush events till the device is connected #54

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Keep trying to flush events till the device is connected #54

merged 3 commits into from
Oct 20, 2023

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Oct 19, 2023 •
edited
Loading

💡 Motivation and Context

If device was disconnected, the flushing boolean would never be flipped

Found by https://github.com/PostHog/posthog-android/pull/53/files#r1365940959

💚 How did you test it?

Real device and unit test

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto changed the title fix/release flushing Keep trying to flush events till the device is connected Oct 19, 2023
@marandaneto marandaneto marked this pull request as ready for review October 19, 2023 18:25
@marandaneto marandaneto mentioned this pull request Oct 19, 2023
Draft
4 tasks
pauldambra
pauldambra approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@marandaneto marandaneto merged commit 50c8d1b into main Oct 20, 2023
7 checks passed
@marandaneto marandaneto deleted the fix/release-flushing branch October 20, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @pauldambra