Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add distinctId() getter to the Public API #33

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Add distinctId() getter to the Public API #33

merged 2 commits into from
Oct 4, 2023

Conversation

marandaneto
Copy link
Member

💡 Motivation and Context

Closes #15

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto marked this pull request as ready for review October 4, 2023 11:10
@marandaneto marandaneto mentioned this pull request Oct 4, 2023
Closed
pauldambra
pauldambra approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@marandaneto marandaneto merged commit 6dd28f0 into main Oct 4, 2023
6 checks passed
@marandaneto marandaneto deleted the chore/distinctId-public branch October 4, 2023 11:56
@marandaneto marandaneto mentioned this pull request Jun 27, 2024
Merged
4 tasks
@marandaneto marandaneto mentioned this pull request Aug 23, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @pauldambra