chore: change screenshot image type from JPEG to WEBP #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
File Info
• Resolution: 1080×2400
• MIME type: image/octet-stream
• Extension: bin
• Size: 6.69 KB
• Download: image.bin
WEBP_LOSSY
File Info
• Resolution: 1080×2400
• MIME type: image/octet-stream
• Extension: bin
• Size: 310.68 KB
• Download: image.bin
WEBP_LOSSLESS
File Info
• Resolution: 1080×2400
• MIME type: image/octet-stream
• Extension: bin
• Size: 6.69 KB
• Download: image.bin
WEBP or WEBP_LOSSY
File Info
• Resolution: 1080×2400
• MIME type: image/png
• Extension: png
• Size: 20.45 KB
• Download: image.png
• Bit depth: 8
PNG
File Info
• Resolution: 1080×2400
• MIME type: image/jpeg
• Extension: jpg
• Size: 20.25 KB
• Download: image.jpg
• Channels: 3
• Bit depth: 8
JPEG
Also this https://github.com/PostHog/posthog-ios/blob/5dceb9b86f6c65c1dcc6d18ae97e1face7236636/PostHog/Replay/PostHogReplayIntegration.swift#L178
Since the base64 image is lossy and loses all metadata, we won't be resending a new snapshot in case nothing changes in the generated image.
💚 How did you test it?
📝 Checklist