Add kafka table and engine #6
Open
+58
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiina303
reviewed
May 17, 2022
| @@ -116,6 +117,11 @@ def __init__(self, db_name, db_url='http://localhost:8123/', | |||
| self.readonly = True | |||
| elif autocreate and not self.db_exists: | |||
| self.create_database() | |||
| self.cluster = cluster | |||
| if self.cluster: | |||
| self.on_cluster_sql = f'ON CLUSTER {cluster}' | |||
There was a problem hiding this comment.
Maybe add a space just in case as having two spaces works, having 0 doesn't
Suggested change
| self.on_cluster_sql = f'ON CLUSTER {cluster}' | |
| self.on_cluster_sql = f' ON CLUSTER {cluster}' |
| kafka_topic_list = '{self.topic}' | ||
| kafka_group_name = '{self.group_id}' | ||
| kafka_format = '{self.format}' | ||
| kafka_num_consumers = {self.num_consumers}""" |
There was a problem hiding this comment.
you're missing the skip broken messages here, not sure about the schema either
| @@ -487,8 +487,8 @@ def create_table_sql(cls, db): | |||
| ''' | |||
| Returns the SQL statement for creating a table for this model. | |||
| ''' | |||
| parts = ['CREATE TABLE IF NOT EXISTS `%s`.`%s` AS `%s`.`%s`' % (db.db_name, cls.table_name(), db.db_name, | |||
| cls.engine.main_model.table_name())] | |||
| parts = [f'CREATE TABLE IF NOT EXISTS `{db.db_name}`.`{cls.table_name()}` AS `{db.db_name}`.`{cls.engine.main_model.table_name()}` {db.on_cluster_sql} ('] | |||
There was a problem hiding this comment.
Why the ')' in the end?
Suggested change
| parts = [f'CREATE TABLE IF NOT EXISTS `{db.db_name}`.`{cls.table_name()}` AS `{db.db_name}`.`{cls.engine.main_model.table_name()}` {db.on_cluster_sql} ('] | |
| parts = [f'CREATE TABLE IF NOT EXISTS `{db.db_name}`.`{cls.table_name()}` AS `{db.db_name}`.`{cls.engine.main_model.table_name()}` {db.on_cluster_sql} '] |
| @@ -511,7 +511,7 @@ def create_table_sql(cls, db): | |||
| Returns the SQL statement for creating a table for this model. | |||
| ''' | |||
| assert isinstance(cls.engine, Merge), "engine must be an instance of engines.Merge" | |||
| parts = ['CREATE TABLE IF NOT EXISTS `%s`.`%s` (' % (db.db_name, cls.table_name())] | |||
| parts = [f'CREATE TABLE IF NOT EXISTS `{db.db_name}`.`{cls.table_name()}` {db.on_cluster_sql} ('] | |||
| Returns the SQL statement for creating a table for this model. | ||
| ''' | ||
| assert isinstance(cls.engine, Kafka), "engine must be an instance of engines.Kafka" | ||
| parts = [f'CREATE TABLE IF NOT EXISTS `{db.db_name}`.`{cls.table_name()}` {db.on_cluster_sql} ('] |
Comment on lines
+624
to
+625
| parts.append(',\n'.join(cols)) | ||
| parts.append(')') |
There was a problem hiding this comment.
Suggested change
| parts.append(',\n'.join(cols)) | |
| parts.append(')') | |
| parts.append('(') | |
| parts.append(',\n'.join(cols)) | |
| parts.append(')') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka would be proud about this metamorphosis