Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: option to exclude specific events #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: option to exclude specific events #15

wants to merge 1 commit into from

Conversation

yusufumac
Copy link

resolves #11

@jamesefhawkins
Copy link

@neilkakkar fyi

neilkakkar
neilkakkar reviewed May 26, 2022
View reviewed changes
Copy link

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but would also be nice to have some validation in setupPlugin that ensures users can't make mistakes: We don't want to allow someone to set both eventsToSend and eventsToExclude. It only makes sense to choose one of these options.

@kappa90
Copy link
Contributor

kappa90 commented Nov 10, 2022

Ok, I honestly didn't see this PR, because I created a basically identical one here 😅 : #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilkakkar neilkakkar neilkakkar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an option to list events to Exclude from sending to Customer.io
4 participants
@yusufumac @jamesefhawkins @kappa90 @neilkakkar