pulseaudio: Rework stopping code that it should prevent artifacts #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illuusio
force-pushed
the
pulseaudio-remove-last-click
branch
from
7c6247c to
d47968e
Compare
philburk
requested changes
Oct 10, 2024
RossBencina
added
the
src-pulseaudio
illuusio
force-pushed
the
pulseaudio-remove-last-click
branch
from
d47968e to
ba5ec87
Compare
Rework stopping and stream closing code as it should prevent artifacts when closing or stopping stream. Correctly handle stream termination from callback
illuusio
force-pushed
the
pulseaudio-remove-last-click
branch
from
ba5ec87 to
77d4d46
Compare
|
This could take a look now that other one is fixed. |
RossBencina
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Github won't let me add a comment to an unchanged line, but at line 429 call to pa_steam_write, nothing has been copied to bufferData yet. Furthermore, bufferData memory is invalidated by the call (see https://freedesktop.org/software/pulseaudio/doxygen/stream_8h.html#a4fc69dec0cc202fcc174125dc88dada7 ) so subsequent calls to the buffer processor may crash.
I suggest moving the calls to PaUtil_EndBufferProcessing and PaUtil_EndCpuLoadMeasurement prior to the call to pa_stream_write.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework stopping and stream closing code as it should prevent artifacts when closing or stopping stream. Correctly handle stream termination from callback