Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Python 2 code to Python 3 #890

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Upgrade Python 2 code to Python 3 #890

merged 4 commits into from
Apr 19, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Apr 2, 2024 •
edited
Loading

Print is a function in Python 3. https://docs.python.org/3/whatsnew/3.0.html

@cclauss cclauss changed the title checkfiledocs.py: Upgrade Python 2 code to Python 3 Upgrade Python 2 code to Python 3 Apr 3, 2024
@RossBencina
Copy link
Collaborator

RossBencina commented Apr 5, 2024 •
edited
Loading

Maybe best to add from __future__ import print_function to avoid gratuitously breaking Python 2 support. I think 2.7 was still the version shipped on MacOS not that long ago.

@cclauss
Copy link
Contributor Author

cclauss commented Apr 5, 2024

macOS no longer ships with Python.

@RossBencina RossBencina merged commit 7171f07 into PortAudio:master Apr 19, 2024
11 checks passed
@RossBencina
Copy link
Collaborator

Thank you!

@cclauss cclauss deleted the patch-1 branch April 19, 2024 22:38
@cclauss cclauss mentioned this pull request Apr 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RossBencina RossBencina RossBencina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @RossBencina