centralize clock handling for pthread_cond_timedwait #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBencina
force-pushed
the
fix_pthread_cond_timedwait_timouts
branch
9 times, most recently
from
2229265 to
0ed8726
Compare
RossBencina
force-pushed
the
fix_pthread_cond_timedwait_timouts
branch
from
0ed8726 to
d839034
Compare
RossBencina
added
src-alsa
This was referenced Jan 20, 2024
s09bQ5
suggested changes
Jan 20, 2024
philburk
requested changes
Jan 21, 2024
…tSystemTime+SystemTimeToFileTime according to http://www.windowstimestamp.com/description. thanks s09bQ5
…return time 0 and log the error with PA_DEBUG.
…le in callers and fallback to pthread_cond_wait when a deadline for pthread_cond_timedwait can not be computed.
…ier commit of this PR.
…C std but one second worth of nsecs fits in signed 32-bit, so avoid long long for better portability.
s09bQ5
reviewed
Jan 21, 2024
|
Looks good to me now. |
philburk
approved these changes
Feb 2, 2024
RossBencina
commented
Feb 2, 2024
|
Note we don't yet have confirmation that this PR resolves #870 |
|
And I can confirm that it fixes #795. Using JACK works now. |
|
No longer gated by #870 (turns out to be unrelated). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOCK_BOOTTIME>CLOCK_MONOTONIC>CLOCK_REALTIME(on Mac use gettimeofday because other clock interfaces are either not available or broken).Used directly or indirectly by pa_jack, pa_alsa, pa_asihpi
Resolves #795, #807.