Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MME: fix comparison of pointers #571

Merged
merged 1 commit into from
May 13, 2021
Merged

MME: fix comparison of pointers #571

merged 1 commit into from
May 13, 2021

Conversation

Be-ing
Copy link
Collaborator

@Be-ing Be-ing commented May 11, 2021

fixes https://bugzilla.audacityteam.org/show_bug.cgi?id=1969

Another old patch from Audacity

@Be-ing Be-ing mentioned this pull request May 11, 2021
Closed
@Be-ing
Copy link
Collaborator Author

Be-ing commented May 11, 2021

CMake build failures seem to be due to transient network errors unrelated to this code.

@RossBencina RossBencina self-requested a review May 13, 2021 00:12
@RossBencina RossBencina requested review from philburk and removed request for philburk May 13, 2021 00:13
@RossBencina RossBencina merged commit febd58e into PortAudio:master May 13, 2021
@Be-ing Be-ing deleted the mme_pointer_comparison branch May 13, 2021 01:06
illuusio pushed a commit to illuusio/portaudio that referenced this pull request Oct 21, 2021
@Be-ing @illuusio
MME: fix comparison of IO buffer sizes in CalculateBufferSettings() (P…
5b59e83 
…ortAudio#571)

Pull in fix from Audacity: https://bugzilla.audacityteam.org/show_bug.cgi?id=1969

The problem was some kind of typo, comparing pointers instead of the values of pointers.
illuusio pushed a commit to illuusio/portaudio that referenced this pull request Oct 21, 2021
@Be-ing @illuusio
MME: fix comparison of IO buffer sizes in CalculateBufferSettings() (P…
b41b141 
…ortAudio#571)

Pull in fix from Audacity: https://bugzilla.audacityteam.org/show_bug.cgi?id=1969

The problem was some kind of typo, comparing pointers instead of the values of pointers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philburk philburk philburk approved these changes

@RossBencina RossBencina RossBencina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Be-ing @RossBencina @philburk