Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow viewing PUM_Logging log file contents via Popup Maker -> Tools #575

Closed
danieliser opened this issue Jun 15, 2018 · 7 comments
Closed

Comments

@danieliser
Copy link
Member

We quietly added PUM_Logging for errors and warnings to v1.7. Now we need to add a way to view those logs.

@fpcorso fpcorso added this to the v1.12 milestone Jun 5, 2020
@fpcorso
Copy link
Contributor

fpcorso commented Jul 10, 2020

@danieliser What are your thoughts on this? Adding this would make it easier to ask for them in support as opposed to asking them to go to /wp-content/xxxx.log

Would it be limited in someway? Maybe only show the first XXXXX lines?

@danieliser
Copy link
Member Author

@fpcorso

  1. Probably a downloadable similar to the system info txt file.

  2. If we are showing it in the admin directly then yea, we could only load a finite amount of data and possibly even deduplicate those messages to only show unique issues.

@danieliser
Copy link
Member Author

danieliser commented Jul 14, 2020

That said I wonder if we could start leveraging the API server and making it so they can do something like this:

  1. Click a button such as "Get Help & Support"
  2. This loads a form that they fill out like normal.
  3. Request permission to submit system info & logs for support needs.
  4. If allowed send the logs & system info to the API server along with an identifier.
  5. Pass the identifier to Help Scout custom widget to view those logs in popup windows.

I've thought about building a "Allow support to login to my site" but I wouldn't want it in the core plugin purely due to the risks that I never want to deal with. But we could do something along these lines.

Alternatively if they are already opted into telemetry we should probably already be sending those logs to our servers for processing to find these issues before others do. I think we can even capture fatal PHP & JS errors from our own files and send them to our debug logs when we get around to rewriting those per another issue.

@fpcorso
Copy link
Contributor

fpcorso commented Jul 16, 2020

@danieliser To keep this issue clear, let's discuss your second comment in a different thread/issue. But, yes, I think there is something to having a support request from within the plugin.

For this issue, I think making it an option as a downloadable file is a good idea. Where should this go? Can we add a new "Error Log" tab to the "Tools" page? So it would be "Beta Versions" "System Info" "Error Log" and "Import / Export" as tabs on that page?

Then, on that tab, maybe we show the X recent (de-duplicated, if possible) with a download error log button underneath, similar to the "System Info" page:
image

@danieliser
Copy link
Member Author

@fpcorso sounds good

fpcorso added a commit that referenced this issue Jul 30, 2020
Also includes some code quality improvements from PHPCS.

Issue #575
fpcorso added a commit that referenced this issue Jul 30, 2020
To better organize this class, let's group the main methods at the top and
move the helpers underneath.

Issue #575
fpcorso added a commit that referenced this issue Jul 30, 2020
To make the methods more consistent, created a new method in the similar TAB_display
style as the other methods.

Issue #575
fpcorso added a commit that referenced this issue Jul 30, 2020
fpcorso added a commit that referenced this issue Jul 30, 2020
Also, fixes some warnings from StyleLint.

Issue #575
@fpcorso
Copy link
Contributor

fpcorso commented Jul 30, 2020

@danieliser This is where I am currently at. Since this is currently the only place within the admin to control the log, should we also have a button to empty the log?

image

fpcorso added a commit that referenced this issue Jul 30, 2020
fpcorso added a commit that referenced this issue Jul 30, 2020
fpcorso added a commit that referenced this issue Jul 30, 2020
fpcorso added a commit that referenced this issue Jul 30, 2020
@danieliser
Copy link
Member Author

@fpcorso Button to empty it would be simple enough and a good addition.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants