Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decidim activity browser #2

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Conversation

ferblape
Copy link
Member

🎩 What? Why?

Please describe your pull request.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@codecov-commenter
Copy link

Codecov Report

Merging #2 (11d0dee) into develop (df7189d) will decrease coverage by 50.42%.
The diff coverage is 20.95%.

@@             Coverage Diff              @@
##           develop       #2       +/-   ##
============================================
- Coverage    90.01%   39.58%   -50.43%     
============================================
  Files         2978     2978               
  Lines        62044    77975    +15931     
============================================
- Hits         55850    30868    -24982     
- Misses        6194    47107    +40913     
Flag Coverage Δ
decidim-accountability ?
decidim-admin 20.48% <19.41%> (-47.85%) ⬇️
decidim-api 14.92% <19.41%> (-37.37%) ⬇️
decidim-assemblies ?
decidim-blogs 20.33% <19.41%> (-39.04%) ⬇️
decidim-budgets ?
decidim-comments 22.45% <19.41%> (-40.11%) ⬇️
decidim-conferences ?
decidim-consultations 24.23% <19.41%> (-39.64%) ⬇️
decidim-core 20.46% <20.95%> (-54.27%) ⬇️
decidim-debates ?
decidim-dev 10.83% <19.41%> (-35.34%) ⬇️
decidim-elections ?
decidim-elections-system-admin ?
decidim-elections-system-public ?
decidim-forms 16.53% <19.41%> (-37.02%) ⬇️
decidim-generators ?
decidim-initiatives 25.74% <19.41%> (-43.34%) ⬇️
decidim-meetings ?
decidim-meetings-system-admin ?
decidim-meetings-system-public ?
decidim-pages 18.71% <19.41%> (-38.64%) ⬇️
decidim-participatory_processes ?
decidim-proposals 26.55% <19.41%> (-40.68%) ⬇️
decidim-proposals-system-admin ?
decidim-proposals-system-public ?
decidim-sortitions 20.61% <19.41%> (-38.82%) ⬇️
decidim-surveys ?
decidim-system 15.85% <19.41%> (-37.86%) ⬇️
decidim-templates 16.60% <19.41%> (-37.18%) ⬇️
decidim-verifications 22.26% <19.41%> (-39.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...controllers/decidim/activity_browser_controller.rb 0.00% <0.00%> (ø)
decidim-core/lib/tasks/decidim_activities.rake 27.58% <27.58%> (ø)
decidim-core/app/models/decidim/activity.rb 100.00% <100.00%> (ø)
decidim-forms/lib/decidim/forms/test.rb 0.00% <0.00%> (-100.00%) ⬇️
decidim-core/app/jobs/decidim/metric_job.rb 0.00% <0.00%> (-100.00%) ⬇️
decidim-core/app/cells/decidim/badges_cell.rb 0.00% <0.00%> (-100.00%) ⬇️
decidim-core/app/cells/decidim/groups_cell.rb 0.00% <0.00%> (-100.00%) ⬇️
decidim-core/app/cells/decidim/members_cell.rb 0.00% <0.00%> (-100.00%) ⬇️
decidim-core/app/jobs/decidim/open_data_job.rb 0.00% <0.00%> (-100.00%) ⬇️
decidim-core/app/cells/decidim/tos_page_cell.rb 0.00% <0.00%> (-100.00%) ⬇️
... and 1581 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df7189d...11d0dee. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants