Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to 0.27 #17

Merged

Conversation

paulinebessoles
Copy link
Contributor

@paulinebessoles paulinebessoles commented Aug 30, 2023

This pull request aims to:

  • add tests to the 0.27 version of the module.
  • implement location and phone number fields to make them configurable

paulinebessoles added 2 commits August 30, 2023 14:54
@paulinebessoles
Copy link
Contributor Author

@ferblape could you please approve the workflow to run so I can check nothing fails in the ci? 😁

@furilo
Copy link
Member

furilo commented Aug 30, 2023

Done!

@paulinebessoles
Copy link
Contributor Author

@furilo sorry, could you run it again? 😊

@furilo
Copy link
Member

furilo commented Aug 30, 2023

https://github.com/PopulateTools/decidim-module-extra_user_fields/actions/runs/6025862629/job/16347687383?pr=17 ? ;)

@armandfardeau
Copy link
Contributor

@paulinebessoles
Copy link
Contributor Author

paulinebessoles commented Aug 30, 2023

@furilo I really hope it's the last time! 🤞

@furilo
Copy link
Member

furilo commented Aug 30, 2023

Haha, don't worry. Dealing with tests, it probably won't ;)

@paulinebessoles paulinebessoles marked this pull request as ready for review August 30, 2023 15:11
@furilo furilo requested a review from ferblape August 30, 2023 15:13
@furilo
Copy link
Member

furilo commented Aug 31, 2023

The PR is looking great! Thanks a lot. Would it make sense to complete the readme? Our version was quite basic...

@paulinebessoles
Copy link
Contributor Author

@furilo I added some extra indications in the README, please tell me if you want some more infos!

Furthermore, I started testing one last time in local and saw that some fields are not displayed event though they should be so please do not merge this PR (or convert to draft) for now 😔

@paulinebessoles
Copy link
Contributor Author

@furilo @ferblape Now the PR is finalized!

Please tell me if you have any change request 😁

@ferblape
Copy link
Member

ferblape commented Sep 4, 2023

Hi @paulinebessoles thanks for the PR it's fantastic and I'm going to merge it right now.

After that we are going to:

  • fix the branches mess, so extra-fields-0-27 branch will go to master
  • then, in master we are going to update the README with much more detail. Your improvements are great but it was in our plate to do a much complete manual
  • third, we'll release the stable 0.27 branch which you could link in your Gemfiles

@ferblape ferblape merged commit 0fee03b into PopulateTools:extra-fields-0-27 Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants