Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update export maps for TypeScript 4.7+ #944

Merged
merged 4 commits into from
Aug 10, 2022
Merged

Update export maps for TypeScript 4.7+ #944

merged 4 commits into from
Aug 10, 2022

Conversation

rossng
Copy link
Contributor

@rossng rossng commented May 23, 2022

TypeScript 4.7 (soon to be released) now has support for exports maps in package.json and ES module output. In packages that already provide an exports field, this can end up hiding the types field, causing builds to break.

These changes should resolve that by specifying types in the exports map itself.

@rossng
Copy link
Contributor Author

rossng commented Aug 1, 2022

@mattgperry would it be possible to merge this?

@rossng rossng mentioned this pull request Aug 8, 2022
Closed
@mattgperry
Copy link
Collaborator

Looks great - thanks!

@mattgperry mattgperry merged commit 3ae251c into Popmotion:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgperry mattgperry mattgperry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossng @mattgperry