Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message compose view cannot be closed #47

Closed
hallettj opened this issue Sep 8, 2019 · 2 comments · Fixed by #49
Closed

Message compose view cannot be closed #47

hallettj opened this issue Sep 8, 2019 · 2 comments · Fixed by #49
Labels
bug Something isn't working released

Comments

@hallettj
Copy link
Contributor

hallettj commented Sep 8, 2019 •
edited
Loading

I think this only affects the production build.
@hallettj hallettj added the bug Something isn't working label Sep 8, 2019
@hallettj hallettj mentioned this issue Nov 3, 2019
Merged
hallettj added a commit that referenced this issue Nov 3, 2019
@hallettj
fix: switch from Reach Router to React Router with hash history (#49)
f532f28 
Memory history with Reach Router did not work in production for absolute
paths. With memory history paths need to be relative to the file path of
the main HTML file. Hash history is easier to work with in this case
- but Reach Router does not support hash history. Thus the switch to
React Router.

Resolves #47
@hallettj
Copy link
Contributor Author

hallettj commented Nov 3, 2019

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hallettj
Copy link
Contributor Author

hallettj commented Nov 4, 2019

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: switch from Reach Router to React Router with hash history PoodleApp/poodle
1 participant
@hallettj