Improve database reverse engineering #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comments for tables and columns. Improve handling of default values.
Introduce a workaround for the missing EF Core handling of `ValueGenerated.OnUpdate`. Fixes PomeloFoundation#877
|
There was an issue previously where The workaround was to use a regular expression to strip away the display width which your PR removes. The orginal upstream type mapping code in CreateMappingFromStoreType now appears to be in ParseStoreTypeName. |
Can probably remove this code as it only applies to Release Candidate not General Availability versions. https://bugs.mysql.com/bug.php?id=89793 >The NON_UNIQUE column in the INFORMATION_SCHEMA.STATISTICS table had type BIGINT prior to MySQL 8.0, but became VARCHAR in MySQL 8.0 with the introduction of the data dictionary. The NON_UNIQUE column now has an integer type again (INT because the column need not be as large as BIGINT).
|
Thanks for pointing out the regression and doing the research on the method to override! |
…r display width to CLR types.
This was referenced Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to reverse engineer views.
Add comments for tables and columns.
Improve handling of default values.
Handle the
CURRENT_TIMESTAMPdefault value fortimestampcolumns correctly.Correctly implement
CURRENT_TIMESTAMPwithON UPDATEclauses.Introduce a workaround for the missing EF Core handling of
ValueGenerated.OnUpdate.Fixes #877
Fixes #867
Fixes #703
Fixes parts of #792 (others are blocked by an EF Core issue)