Explicit loading test #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
caleblloyd
commented
Nov 1, 2016
caleblloyd
commented
- Here is a test to display how Explicit Loading works
- It works out of the box with EF 1.1.0-preview1, no additional changes needed by us
yukozh
reviewed
Nov 2, 2016
| // explicit load AdminMenus | ||
| await db.Entry(superUser).Collection(m => m.AdminMenus).LoadAsync(); | ||
| // explicit load each Menu | ||
| foreach (var adminMenu in superUser.AdminMenus) |
There was a problem hiding this comment.
Could you use Parallel.ForEach instead of foreach & await?
Or Task.WaitAll()?
There was a problem hiding this comment.
Oh yes, I think Task.WhenAll may be best. I will change that
caleblloyd
force-pushed
the
test_explicit_loading
branch
from
e212560 to
ea698e9
Compare
|
I think Microsoft may be bumping from 1.1.0-preview1 to 1.1.0 soon, which is why AppVeyor is failing. I will wait until I can fix build issues to merge. |
caleblloyd
force-pushed
the
test_explicit_loading
branch
from
ea698e9 to
6fc3d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.