feat(): intersectsLine line type
#213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaMan123
commented
Jan 21, 2024
There was a problem hiding this comment.
I tried out basis change 0f25a14 and indeed it fixed the precision error
Now 2 tests are failing, but since both of them are degenerated beziers maybe this should happen. If I understand correctly the basis change, it means both lines coincide after applying the basis change.
src/utils.js
Outdated
| return points.map((p) => { | ||
| const x = p.x - tx; | ||
| const y = p.y - ty; | ||
| // Apply a basis change on x,y to align the x axis of the curve with the line |
There was a problem hiding this comment.
not sure the comment is 100% accurate
I understand that the curve moves to p1, p1 becoming its zero point and is rotated to align its x axis with the line.
Is that correct?
|
I logged some values and it seems I am right |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I have use cases in which I need to specify the line type (line, ray, segment) for different use cases, e.g. ray casting algorithm to determine if point is contained in a closed shape, segment for rect/bezier intersections and line for finding extreme points on the bezier that intersect without needs to get the hull/bbox
Changes
I have changed to
lineIntersectsmethod to respect the 3 types of line, segment being the default value as it is currently.The
linecase test I have added surfaced a bug inrootsor at least a precision error that creates quite a substantial difference. I tried debugging it and saw that when I pass a line and a line pointing to the opposite direction thealignedmethod rotates the curve wrt the line and that is where the precision error originates.I wonder if using a change basis calculation will fix this (I will try).
If not maybe consider sorting the line points so that the output is the same for both cases.
I admire your work
Thanks for this great repo