Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic format! #648

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Automatic format! #648

merged 1 commit into from
Apr 19, 2018

Conversation

e111077
Copy link
Contributor

@e111077 e111077 commented Apr 10, 2018

Runs the experimental autoformatter webmat which runs clang-format on js files and makes it so that it can run on HTML files. Please look through this PR with ?w=1 in the diff to make sure that no logic was changed.

What has changed?
You can run the formatter on the whole project by running npm run format and ex/include files from the formatter, and enter your custom clang-format config in a formatconfig.json see webmat readme for more!

Copy link
Contributor

@dfreedm dfreedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for travis config

@e111077
Copy link
Contributor Author

e111077 commented Apr 18, 2018

ping

Copy link
Contributor

@notwaldorf notwaldorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please run the tests before merging

@e111077 e111077 merged commit f90cfb4 into master Apr 19, 2018
@e111077 e111077 deleted the auto-cleanup branch April 19, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants