Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Fix #269: TypeError: observerHandle is null in Firefox #270

Closed
wants to merge 1 commit into from

Conversation

TrebuhD
Copy link

@TrebuhD TrebuhD commented Mar 2, 2018

This fixes the linked issue, but I'm not 100% sure it won't break anything under the hood.

@TrebuhD TrebuhD requested a review from valdrinkoshi as a code owner March 2, 2018 11:04
@googlebot
Copy link

Thanks for your pull request. t looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@TrebuhD
Copy link
Author

TrebuhD commented Mar 2, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@valdrinkoshi
Copy link
Member

I'll close this for now, as we're working with @TrebuhD to provide details on the bug in #269.
The fix will require unit tests in order to avoid future regressions

@TrebuhD
Copy link
Author

TrebuhD commented Aug 19, 2018

Maybe we should consider reopening this in light of the conversation over at #269 and quite a few people reporting being affected by this bug?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants